Open
Conversation
DominicOram
suggested changes
Dec 20, 2019
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
I don't think this quite works as expected, see comments.
| import argparse | ||
|
|
||
| # Import the configurations upgrade tool | ||
| sys.path.append( os.path.join("C:\\", "Instrument", "Apps", "EPICS", "misc", "upgrade", "master")) |
Contributor
There was a problem hiding this comment.
Can you use the EPICS_ROOT environment variable here?
| @@ -69,6 +72,9 @@ | |||
| else: | |||
| shutil.copy(file_or_dir_src, dest) | |||
Contributor
There was a problem hiding this comment.
This ends up copying config_version.txt to machine_name/configurations/configurations it should actually live in machine_name/configurations otherwise the upgrade script won't find it.
| shutil.copy(file_or_dir_src, dest) | ||
|
|
||
| print("\n\n------ UPGRADING configurations ------") | ||
| perform_upgrade() |
Contributor
There was a problem hiding this comment.
I get an error when this is run of No such file or directory: "src\\schemas\\new_banner.xsd"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
As above
Ticket
#5048
Acceptance criteria
List the acceptance criteria for the PR. The aim is provide information to help the reviewer
Unit tests
Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer
System tests
Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer
Code Review
Final Steps